On Mon, May 18, 2020 at 8:21 PM Aldy Hernandez via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > As a follow-up to the patch moving array bounds checking into its own > class, this moves the class into its own files. As I've mentioned > previously, having it in tree-vrp just pollutes the file with unrelated > stuff. > > Jeff, I know you've mentioned you'd like to move the array bounds > checking to the path isolation pass at some point. Would the current > approach work for you? I'm ok, inasmuch as it's gone from tree-vrp.c, > the file is bloated enough as it is.
> wc -l gcc/tree-vrp.c 5586 gcc/tree-vrp.c > wc -l gcc/vr-values.c 4361 gcc/vr-values.c > wc -l gcc/range-op.cc 3113 gcc/range-op.cc I wouldn't call this bloated. Moving to separate files is hardly a good thing on its own. > > Aldy
