Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> writes: > On Thu, May 21, 2020 at 10:03:37AM +0200, Martin Liška wrote: >> On 5/21/20 9:56 AM, Jakub Jelinek wrote: >> > Can't it be __attribute__((target ("outline-atomics"))) instead? >> >> Ah sorry, I wan unclear. >> It's support the this _target_ attribute which you mentioned. > > Ok, better, will defer review to target maintainers of course. > But the above clearly shows you forgot to add testcase coverage, > both that dg-options -moutline-atomics target "no-outline-atomics" > routine with scan-assembler and the other way around.
Yeah, agree it'd be worth having tests for both directions. The patch itself looks good though -- thanks for doing this. Richard