Hi, > -----Original Message----- > From: Segher Boessenkool [mailto:seg...@kernel.crashing.org] > Sent: Saturday, May 23, 2020 10:57 PM > To: Yangfei (Felix) <felix.y...@huawei.com> > Cc: gcc-patches@gcc.gnu.org; Zhanghaijian (A) <z.zhanghaij...@huawei.com> > Subject: Re: [PATCH PR94026] combine missed opportunity to simplify > comparisons with zero > > Hi! > > Sorry this is taking so long. > > On Wed, May 06, 2020 at 08:57:52AM +0000, Yangfei (Felix) wrote: > > > On Tue, Mar 24, 2020 at 06:30:12AM +0000, Yangfei (Felix) wrote: > > > > I modified combine emitting a simple AND operation instead of > > > > making one > > > zero_extract for this scenario. > > > > Attached please find the new patch. Hope this solves both of our > concerns. > > > > > > This looks promising. I'll try it out, see what it does on other > > > targets. (It will have to wait for GCC 11 stage 1, of course). > > It creates better code on all targets :-) A quite small improvement, but not > entirely trivial.
Thanks for the effort. It's great to hear that :- ) Attached please find the v3 patch. Rebased on the latest trunk. Bootstrapped and tested on aarch64-linux-gnu. Could you please help install it? > > > p.s. Please use a correct mime type? application/octet-stream > > > isn't something I can reply to. Just text/plain is fine :-) > > > > I have using plain text now, hope that works for you. :-) > > Nope: > > [-- Attachment #2: pr94026-v2.diff --] > [-- Type: application/octet-stream, Encoding: base64, Size: 5.9K --] This time I switched to use UUEncode type for the attachment. Does it work? I am using Outlook and I didn't find the place to change the MIME type : - ( Felix
pr94026-v3.diff
Description: pr94026-v3.diff
