> Hmm, MAX_BITSIZE_MODE_ANY_INT looks a bit arbitrary since on > x86 it (IIRC) includes things like OImode. Maybe MOVE_MAX or > MAX_FIXED_MODE_SIZE are better suited here?
You're right, MAX_FIXED_MODE_SIZE is better, I'm going to change it. > The IL correctness fix looks OK to me but it smells like we > might have issues with inserting into x86 XFmode fields > where ordinary XFmode stores store less bytes than > an integer mode of the same size? That issue should be > latent of course (unless it always ICEd before). Also > it's likely reproducible only on Ada(?). Yes, this can only happen in Ada because it effectively can have bit-fields of any type, and not only of integral types. -- Eric Botcazou
