Hi,
On Thu, 21 May 2020 at 02:07, Jonathan Wakely via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > On 21/05/20 01:01 +0100, Jonathan Wakely wrote: > >Also add some missing member functions, nodiscard attributes, and > >noexcept-specifiers. > > > > * include/experimental/executor (use_future_t::use_future_t()): Fix > > incorrect noexcept-specifier. > > * include/experimental/internet (basic_resolver_results): Adjust > > whitespace. > > * include/experimental/socket (__basic_socket_impl::release): Add > > member function. > > (basic_socket(io_context&, const endpoint_type&)): Fix argument to > > target constructor. > > (basic_socket::release(), basic_socket::release(error_code&)): Add > > missing member functions. > > (basic_socket::is_open()): Add nodiscard attribute. > > (basic_socket::close(error_code&)): Pass argument to base function. > > (basic_socket_acceptor::release()) > > (basic_socket_acceptor::release(error_code&)): Add missing member > > functions. > > (basic_socket_acceptor::is_open()): Add nodiscard attribute. > > (basic_socket_streambuf::error()): Add noexcept. > > (basic_socket_iostream::error()): Likewise. > > * testsuite/experimental/net/socket/basic_socket.cc: New test. > This new test fails to compile on newlib targets (aarch64-elf, arm-eabi) because: include/experimental/executor:509: error: 'mutex' in namespace 'std' does not name a type include/experimental/executor:556: error: 'mutex' is not a member of 'std' [...] I'm not sure what effective-target is needed here? Thanks, Christophe > This adjusts the nodiscard attributes to use the _GLIBCXX_NODISCARD > macro for consistency (even though that means the attribute isn't > there for C++14 mode). > > Tested powerpc64le-linux, committed to master. >
