On Thu, May 28, 2020, 4:25 PM David Malcolm via Gcc-patches < gcc-patches@gcc.gnu.org> wrote:
> On Wed, 2020-05-27 at 22:27 -0300, Nicolas Bértolo wrote: > > > New C++ source files should have a .cc extension. > > > I hope that at some point we'll rename all the existing .c ones > > > accordingly. > > > > I just couldn't get Make to generate jit-w32.o from jit-w32.cc. > > It looks for jit-w32.c. > > > > I had to leave it with the .c extension. > > Fair enough. > That's not a good reason to leave it like this. You should get a make expert to help here. I was able to successfully bootstrap and regression test with your > patch on x86_64-pc-linux-gnu. I also verified that the result of "make > install" was not affected for my configuration. > > I've pushed your patch to master as > c83027f32d9cca84959c7d6a1e519a0129731501. > > (I had to do a little fixup of the ChangeLog entries to get them to > work with the new hooks on our git repo) > > Thanks again for the patch > Dave > > [1] > https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/aa379560(v=vs.85) I don't want to sound confrontational, but I don't think testing this on linux and reviewing it by non windows experts is correct. At the very least, a windows maintainer (Jon, Kai) should review it for correctness. I've cc'd them here.
