On 6/11/20 10:48 AM, Jonathan Wakely wrote:
On 11/06/20 09:54 +0200, Martin Liška wrote:
On 6/10/20 2:20 PM, Jonathan Wakely wrote:
Oops, this line was left in while I was testing it by amending
existing commits!
Here's an updated patch without that line.
I generally like the suggested idea and I have suggestion to usage of the
GCC_FORCE_MKLOG.
Right now, we use the env variable only in 'git config alias.gcc-commit-mklog'
alias.
Ah yes, I forgot about that alias (I don't use it).
I use it (and I want to distinguish in between it and normal commit command) ;)
Wouldn't it be better to only add
git config gcc-config.mklog-hook-type [always|smart-amend]
and do not support GCC_FORCE_MKLOG=no or GCC_FORCE_MKLOG=smart-amend?
Sure, that works for me.
Or do you have always GCC_FORCE_MKLOG=1 on (I mean for git commit)?
No, I was actually using a modified version of the script that didn't
check the env var at all, because I always wanted it to be used.
I bet some other people (including me) want to have 2 different commands.
I'll prepare a patch that replaces the env var completely, and also
modifies the contrib/gcc-git-customization.sh script to optionally
enable the hook.
I would preserve it for the alias.
Martin
Do we want to drop the gcc-config.gcc-commit-mklog alias now, since it
won't do anything different from 'git commit'?
