On Mon, Dec 26, 2011 at 09:28:01AM -0800, Steve Kargl wrote:
> On Mon, Dec 26, 2011 at 05:14:46PM +0100, Dominique Dhumieres wrote:
> > > I regression tested the patch on i686-*-freebsd. No problems occurred.
> > > Can one of the other gfortran reviewers/committers cast a quick glance
> > > over the patch. I would like to commit this within next day or two.
> >
> > I have applied the patch on trunk (incremental update). I did not get any
> > regression on x86_64-apple-darwin10 with either -m32 or -m64.
>
> Thanks for testing.
>
> > I get
> >
> > === gfortran Summary for unix/-m32/-finteger-4-integer-8 ===
> >
> > # of expected passes 37336
> > # of unexpected failures 896
> > # of expected failures 39
> > # of unresolved testcases 1
> > # of unsupported tests 570
> >
In gfortran.fortran-torture/execute, I did the simply test of
#! /bin/csh
foreach i (*.f90)
echo $i
gfortran -O -finteger-4-integer-8 -o z $i
./z
end
These 6 tests all aborted:
intrinsic_bitops.f90
intrinsic_leadz.f90
intrinsic_si_kind.f90
intrinsic_trailz.f90
iolength_1.f90
iolength_2.f90
iolength_3.f90
There were no ICE's.
Inspection of the tests show that indeed the programs should
abort. For example, the guts of iolength_3.f90 are
integer, parameter :: int32 = selected_int_kind(9)
integer(int32) :: a, b, iol
real(dp) :: c
inquire (iolength = iol) a, b, c
if ( 16 /= iol) then
call abort
end if
With -finteger-4-integer-8, iol should be 24.
--
Steve
