Thomas Schwinge <tho...@codesourcery.com> writes: Hi Thomas,
> (CC <fort...@gcc.gnu.org> added, for everything touching gfortran.) Thanks! > On 2020-07-07T10:52:08+0200, Frederik Harwath <frede...@codesourcery.com> > wrote: >> This patch fixes the check for reductions on orphaned gang loops > > This is the "Make OpenACC orphan gang reductions errors" functionality > originally added in gomp-4_0-branch r247461. > >> the Fortran frontend which (in contrast to the C, C++ frontends) >> erroneously rejects reductions on gang loops that are contained in >> "kernels" constructs and which hence are not orphaned. >> >> According to the OpenACC standard version 2.5 and later, reductions on >> orphaned gang loops are explicitly disallowed (cf. section "Changes >> from Version 2.0 to 2.5"). Remember that a loop is "orphaned" if it is >> not lexically contained in a compute construct (cf. section "Loop >> construct" of the OpenACC standard), i.e. in either a "parallel", a >> "serial", or a "kernels" construct. > > Or the other way round: a 'loop' construct is orphaned if it appears > inside a 'routine' region, right? The "not lexically contained in a compute construct" definition is from the standard. Assuming that the frontend's parser rejects "loop" directives if they do not occur inside of either the "serial", "parallel", "kernels" compute constructs or in a function with a "routine" directive, both definitions should be indeed equivalent ;-). > Unless Julian/Kwok speak up soon: OK, thanks. > > Reviewed-by: Thomas Schwinge <tho...@codesourcery.com> > > May want to remove "libgomp" from the first line of the commit log -- > this commit doesn't relate to libgomp specifically. Right. > (Ideally, we'd also test 'serial' construct in addition to 'kernels', > 'parallel', but we can add that later. I anyway have a WIP patch > waiting, adding more 'serial' construct testing, for a different reason, > so I'll include it there.) I had left this out intentionally, because having the gang reduction in the serial construct leads to a "region contains gang partitioned code but is not gang partitioned" error. Of course, we might still add a test case with that expectation. Thanks for the review! Frederik ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
