On Thu, Jul 16, 2020 at 09:16:06AM -0400, Nathan Sidwell wrote:
> On 7/15/20 6:59 PM, Marek Polacek wrote:
> > The convert_like* macros were introduced in
> >
> > 2000-03-05 Nathan Sidwell <nat...@codesourcery.com>
> >
> > * call.c (convert_like): Macrofy.
> > (convert_like_with_context): New macro.
> >
> > but now we can use overloading so we can do away with the macros.
> > I've also taken this chance to rename _real to _internal to make it
> > clear that it should not be called directly.
>
> ok, a nit ...
>
> > +/* Wrapper for convert_like_internal that handles creating
> > + IMPLICIT_CONV_EXPR. */
> > +
> > +static tree
> > +convert_like (conversion *convs, tree expr, tree fn, int argnum,
> > + bool issue_conversion_warnings,bool c_cast_p,
>
> missing space after comma
Oop, will fix.
> > + tsubst_flags_t complain)
> > +{
>
> > +
> > +/* Convenience wrapper for convert_like. */
> > +
> > +static inline tree
> > +convert_like (conversion *convs, tree expr, tsubst_flags_t complain)
>
> It's unfortunate the argument ordering is not friendly to using default
> args. Reordering would be too much churn I suspect. Let's not go there.
Yeah, that was my thinking too.
Thanks,
Marek
