Hi! (All that Will says included by reference ;-) )
On Mon, Aug 24, 2020 at 02:39:41PM -0700, Carl Love wrote: > I attempted to do the backport however the patch doesn't even come > close to applying. The names XVCVBF16SPN and XVCVSPBF16 are the only > two builtin names that exist in GCC 10. The other issue is there is no > Power 10 builtin macro definitions in GCC 10. So basically, I can fix > the issue with XVCVBF16SPN and XVCVSPBF16 to be restricted to Power 10 > by adding the needed Power 10 macro definition. Okay, that is what we should do I agree. > This is a whole new patch so I figure it needs to be reviewed to make > sure we want to make this change to GCC 10. I did run the regression > tests again using a Power 9 machine to verify it complies and there are > no regression test failures. > > Please let me know if this is OK for the GCC 10 tree. Thanks. The patch looks fine. It now is impossible to write a correct changelog for a backport like this, so I won't review that part. Please make it clear that this is a partial backport in the commit message (and commit of what ofc). Okay for trunk with that. Thanks! Segher
