Hi! On Wed, Sep 30, 2020 at 05:01:45PM +0930, Alan Modra wrote: > * config/rs6000/linux64.h (SUBSUBTARGET_OVERRIDE_OPTIONS): Don't > set -mcmodel=small for -mno-minimal-toc when pcrel.
> - SET_CMODEL (CMODEL_SMALL); \ > + if (TARGET_MINIMAL_TOC \ > + || !(TARGET_PCREL \ > + || (PCREL_SUPPORTED_BY_OS \ > + && (rs6000_isa_flags_explicit \ > + & OPTION_MASK_PCREL) == 0))) \ > + SET_CMODEL (CMODEL_SMALL); \ Please write this in a more readable way? With some "else" statements, perhaps. It is also fine to SET_CMODEL twice if that makes for simpler code. The rest looks fine, fwiw. Segher
