Hi!

On Thu, Nov 19, 2020 at 06:43:02PM -0500, Michael Meissner wrote:
> One feature of the current GNU attribute implementation is if you have a 
> shared
> library (such as libgcc_s.so), the GNU attributes for the shared library is an
> inclusive OR of all of the modules within the library.  This means if any
> module uses the -mlong-double-128 option and uses long double, the GNU
> attributes for the library will indicate that it uses 128-bit IBM long
> doubles.  If you have a static library, you will get the warning only if you
> actually reference a module with the attribute set.

(You use "module" a lot, here and in the patch; just "object file" would
be clearer I think.  "Module" has a specific (and different)( meaning in
many contexts.)

>     2) I turned off GNU attributes for building the shared library or for
>         building the IBM 128-bit long double support.

It's not clear to me what error disabling setting it for the static
library avoids?  Not that it *hurts* of course.  Do you have an example
for this?

Anyway, okay for trunk (and backports later).  Thanks!


Segher

Reply via email to