On 11/20/20 4:14 PM, Jeff Law wrote:
>
> On 11/20/20 11:12 AM, Martin Sebor via Gcc-patches wrote:
>> dump_function_to_file prints DECL_ATTRIBUTES but not TYPE_ATTRIBUTES
>> when both can be important and helpful for debugging, especially with
>> attributes that are added implicitly (such attribute access and
>> the proposed internal attribute *dealloc). The function also prints
>> function arguments (and their types) but not its return type, again,
>> leaving out a useful detail. The attached tweak adds both to
>> the dump.
>>
>> Martin
>>
>> gcc-dump-type-attr.diff
>>
>> gcc/ChangeLog:
>>
>> * gcc/tree-cfg.c (dump_function_to_file): Print type attributes
>> and return type.
>>
>> gcc/testsuite/ChangeLog:
>> * gcc.dg/attr-access-4.c: New test.
So was this actually regression tested? Even tests that change dump
files need to be regression tested because some of the tests scan those
dump files.
I'm seeing this on several targets:
Tests that now fail, but worked before (6 tests):
xstormy16-sim: gcc.dg/tree-ssa/pr23401.c scan-tree-dump-times gimple "int" 5
xstormy16-sim: gcc.dg/tree-ssa/pr23401.c scan-tree-dump-times gimple "int" 5
xstormy16-sim: gcc.dg/tree-ssa/pr27810.c scan-tree-dump-times gimple "int" 3
xstormy16-sim: gcc.dg/tree-ssa/pr27810.c scan-tree-dump-times gimple "int" 3
xstormy16-sim: gcc.dg/tree-ssa/slsr-8.c scan-tree-dump-times optimized " w?\\*
" 9
xstormy16-sim: gcc.dg/tree-ssa/slsr-8.c scan-tree-dump-times optimized " w?\\*
" 9
>From my quick reading, these tests are likely failing across the board.
jeff
