Hello Thomas, On 15.11.20 18:52, Thomas Koenig via Fortran wrote:
this patch makes sure that we pass the correct fn decls for some of our library functions. cshift and others still remain to be implemented.
Thanks
+#define ADD_CHAR(c) do { *fp++ = c; *fp++ = ' '; } while(0) ... + ADD_CHAR ('.'); /* Function return. */
Shouldn't this be ".c" instead of ". " as neither global memory is read nor written to?
+ if (expr->rank == 0) + { + if (expr->ts.type == BT_CHARACTER) + { + ADD_CHAR ('w'); /* Address of character. */ + ADD_CHAR ('.'); /* Length of character. */ + } + } + else + ADD_CHAR ('w'); /* Return value is a descriptor. */
shouldn't this be "o"? Otherwise, it looks good to me. Tobias ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter