On Fri, Nov 27, 2020 at 06:18:46PM +0100, Tobias Burnus wrote:
> '!' starts in Fortran a comment (+ fixed-form variants)
> OpenACC defines as sentinel "!$acc" (likewise)
> But OpenMP has two: Besides "!$omp" there is additionally
> "!$ " (with space) to permit conditional compilation.
>
> Currently, -fopenacc also executes the '!$ ' code, which I
> think does not make sense.
>
> Hence, this patch ignores it.
> Comments? If not, I intent to commit it in the next days
Depends on what does the OpenACC standard say.
If it has similar wording to OpenMP that '!$ ' stands for OpenACC
conditional compilation, then the patch is incorrect, if it is silent on
that, then the patch is correct.
What about fixed-form parsing? Does it also recognize the conditional
compilation in OpenACC or not? Tests should cover that too, I guess
including -fopenmp -fopenacc goacc-gomp test that would test that it still
works (both free form and fixed form).
Jakub
