On 12/3/20 7:08 AM, Alexandre Oliva wrote:
> On Dec 3, 2020, Christophe Lyon <christophe.l...@linaro.org> wrote:
>
>> This patches causes a lot of regressions in fortran on arm and aarch64,
> On Dec 3, 2020, Andreas Schwab <sch...@linux-m68k.org> wrote:
>
>> On Dez 03 2020, Andreas Schwab wrote:
>>> ../../../../libffi/src/aarch64/ffi.c: In function 'ffi_prep_closure_loc':
>>> ../../../../libffi/src/aarch64/ffi.c:67:3: error: both arguments to
>>> '__builtin___clear_cache' must be pointers
>>> 67 | __builtin___clear_cache (start, end);
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> This happens when compiling with -mabi=ilp32.
> Thank you both. Here's the patch I'm testing to fix both issues.
> Ok to install?
>
>
> fix __builtin___clear_cache overrider fallout
>
> From: Alexandre Oliva <ol...@adacore.com>
>
> Machines that had CLEAR_CACHE_INSN and that would thus issue calls to
> __clear_cache with the default call expander, would fail on languages
> that did not set up the __clear_cache builtin. This patch arranges
> for all languages to set up this builtin.
>
> Machines or multilibs that had ptr_mode != Pmode, such as aarch64 with
> -mabi=ilp32, would fail the RTL mode test of the arguments passed to
> __clear_cache, because we'd insist on ptr_mode. This patch arranges for
> Pmode to be accepted as well.
>
>
> for gcc/ChangeLog
>
> * tree.c (build_common_builtin_nodes): Declare
> __builtin___clear_cache for all languages.
> * builtins.c (maybe_emit_call_builtin___clear_cache): Accept
> Pmode arguments.
OK
jeff
