On Sat, Jan 09, 2021 at 07:44:31PM +0100, Matthias Klose wrote:
> These warnings, including the suggested fixes are seen on power*-linux builds.
>
> warning: misspelled term 'builtin function' in format; use 'bult-in function'
> instead [-Wformat-diag]
This one is wrong. Almost all the functions are called __builtin_xxx
so changing the warning message like that is just silly. Instead, just
rephrase it so you do not need to repeat it,
The warning message itself is buggy: it pretends it knows what it is
talking about. No warning ever does, that is the difference between
warnings and errors.
The hint (after the semi-colon) is extra wrong.
> warning: spurious trailing punctuation sequence '].' in format [-Wformat-diag]
This is also wrong (it says
error ("Second argument of %qs must be in the range [0, 3].", name);
which is obviously correct: "]" is not punctuation, and that makes the
error message (again, not phrased as a warning) incorrect as well.
> warning: misspelled term 'floating point' in format; use 'floating-point'
> instead [-Wformat-diag]
It is a a noun here, which is spelled without dash. The warning is
mistaken, and its advice (not phrased as advice) is bad advice.
[-- Attachment #2: format-diag.diff --]
[-- Type: text/x-patch, Encoding: quoted-printable, Size: 2.2K --]
Please use plain text attachments, so that people can a) read it on the
mail archives, and b) apply the patches easily, etc.
Segher
