On Fri, 2020-12-25 at 03:21 -0300, Alexandre Oliva wrote: > The getpass function is not available on all systems; and not > necessarily declared in unistd.h, as expected by the sensitive-1 > analyzer test. > > Since this is a compile-only test, it doesn't really matter if the > function is defined in the system libraries. All we need is a > declaration, to avoid warnings from calling an undeclared function. > This patch adds the declaration, in a way that is most unlikely to > conflict with any existing declaration. > > Regstrapped on x86_64-linux-gnu, also tested on arm-vxworks7r2. > Ok to install?
The patch looks good to me. Technically I'm not a reviewer for the analyzer, but I think you can go ahead under the "obvious" rule. Thanks Dave