On Mar 9, 2021, Segher Boessenkool <seg...@kernel.crashing.org> wrote:
> Hi! > On Wed, Mar 03, 2021 at 06:07:29PM -0300, Alexandre Oliva wrote: >> On Mar 3, 2021, Segher Boessenkool <seg...@kernel.crashing.org> wrote: >> It's skipping the test, as the change you propose, that reduces testing >> surface, when testing only a configuration that ends up skipping it. > Not at all. There are very many more configurations that have floating > point disabled then that there are configurations with FP enabled but > without square root insns (almost no one targets G4 anymore, it is over > twenty years old). Your change causes the test to be skipped. How does that not reduce the testing surface? > In any case, the existing code did not do two necessary checks. I > corrected that. I agree your change is correct, and a step in the right direction, it's just not sufficient to address all of the problems that have been brought up in this interaction. >> > This is fixed trivially by the PR99352 patch as far as I can see. >> If your patch also deals with the ICE that appears with the options >> named in PR99372, great. > It does afaics. Please check? I still get an ICE when I compile the testcase with the options mentioned in the testcase. Don't you? -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
