Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> writes: > On Wed, Apr 07, 2021 at 03:53:26PM +0200, Jakub Jelinek via Gcc-patches wrote: >> On Mon, Mar 29, 2021 at 11:16:55AM +0200, Jakub Jelinek wrote: >> > > Looks good to me. Richard E knows this code better than I do though, >> > > so I think he should have the final say. He's currently on holiday >> > > but will be back next week. >> > >> > I'd like to ping this patch. >> >> Ping. > > Ping.
Let's go for it. I still think the patch looks good, and if a problem crops up then we still have time to fix it before the release. Applying it now seems better than applying it closer to the release. Thanks, Richard > >> > > > 2021-03-18 Jakub Jelinek <ja...@redhat.com> >> > > > >> > > > PR target/91710 >> > > > * config/aarch64/aarch64.c (aarch64_function_arg_alignment): >> > > > Change >> > > > abi_break argument from bool * to unsigned *, store there the >> > > > pre-GCC 9 >> > > > alignment. >> > > > (aarch64_layout_arg, aarch64_gimplify_va_arg_expr): Adjust >> > > > callers. >> > > > (aarch64_function_arg_regno_p): Likewise. Only emit -Wpsabi >> > > > note if >> > > > the old and new alignment after applying MIN/MAX to it is >> > > > different. >> > > > >> > > > * gcc.target/aarch64/pr91710.c: New test. > > Thanks > > Jakub