On 4/21/2021 2:18 AM, Martin Liška wrote:
Hello.

The patch silents Clang warnings:
1) if (TARGET_MACHO
) ...
  #if TARGET_MACHO

can be replaced with #if TARGET_MACHO

2) add_AT_vms_delta is used only if VMS_DEBUGGING_INFO is defined
3) tree.c:13454:16: warning: result of comparison of constant 42405 with 
expression of type 'enum tree_code' is always false 
[-Wtautological-constant-out-of-range-compare]

4) use canonical (more common form) of a condition that's intentionally 
disabled.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Ready to be installed?
Thanks,
Martin

gcc/ChangeLog:

        * config/i386/i386.c: Remove superfluous || TARGET_MACHO
        which remains to be '(... || 0)' and clang complains about it.
        * dwarf2out.c (AT_vms_delta): Declare conditionally.
        (add_AT_vms_delta): Likewise.
        * tree.c (fld_simplified_type): Use rather more common pattern
        for disabling of something (#if 0).
        (get_tree_code_name): Likewise.
        (verify_type_variant): Likewise.

OK

jeff

Reply via email to