On Wed, Apr 28, 2021 at 10:43 PM Levy Hsu <ad...@levyhsu.com> wrote: > From: LevyHsu <ad...@levyhsu.com> > > Added implementation for builtin overflow detection, new patterns are > listed below. >
This looks OK. You are missing a ChangeLog entry. I added one. I had to fix some whitespace and formatting issues. Open parens should line up in the RTL patterns. There should be no lines that start with 8 spaces, use a tab instead. There should be no lines with only whitespace on them. You didn't indent open curly braces in some places. You missed indenting the first line in a pattern. You had a blank line at the start of an output template. All simple stuff that I fixed. Then committed the patch. Jim
