Hi Segher,
on 2021/7/8 上午1:10, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Jul 07, 2021 at 05:03:23PM +0800, Kewen.Lin wrote:
>> This patch is to make Power10 newly introduced vector
>> modulo instructions exploited in vectorized loops, it
>> just simply renames existing define_insns as standard
>> pattern names.
>
>>
>> Is it ok for trunk?
>>
>> BR,
>> Kewen
>> -----
>> gcc/ChangeLog:
>>
>> * config/rs6000/rs6000-builtin.def (MODS_V2DI, MODS_V4SI, MODU_V2DI,
>> MODU_V4SI): Adjust.
>> * config/rs6000/vsx.md (mods_<mode>): Renamed to...
>> (mod<mode>3): ... this.
>> (modu_<mode>): Renamed to...
>> (umod<mode>3): ... this.
>
> ("Rename", not "Renamed")
>
oh, forgot to use imperative form, will fix.
> (It reads better if you put the "Adjust" entry after the rest, btw)
>
Will switch them. :)
> So I suppose the new testcase FAILs without these changes?
>
Yes, it fails without these changes.
> Okay for trunk. Thanks!
>
Thanks for the reviews!
BR,
Kewen
