RE: [PATCH 5/8] aarch64: Use memcpy to copy vector tables in vst4[q] intrinsics

[Kyrylo Tkachov via Gcc-patches]

> -----Original Message-----
> From: Jonathan Wright <jonathan.wri...@arm.com>
> Sent: 23 July 2021 10:22
> To: gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov <kyrylo.tkac...@arm.com>; Richard Sandiford
> <richard.sandif...@arm.com>
> Subject: [PATCH 5/8] aarch64: Use memcpy to copy vector tables in vst4[q]
> intrinsics
> 
> Hi,
> 
> This patch uses __builtin_memcpy to copy vector structures instead of
> building a new opaque structure one vector at a time in each of the
> vst4[q] Neon intrinsics in arm_neon.h. This simplifies the header file
> and also improves code generation - superfluous move instructions
> were emitted for every register extraction/set in this additional
> structure.
> 
> Add new code generation tests to verify that superfluous move
> instructions are no longer generated for the vst4q intrinsics.
> 
> Regression tested and bootstrapped on aarch64-none-linux-gnu - no
> issues.
> 
> Ok for master?

Ok.
Thanks,
Kyrill

> 
> Thanks,
> Jonathan
> 
> ---
> 
> gcc/ChangeLog:
> 
> 2021-07-20  Jonathan Wright  <jonathan.wri...@arm.com>
> 
>       * config/aarch64/arm_neon.h (vst4_s64): Use __builtin_memcpy
>       instead of constructing __builtin_aarch64_simd_xi one vector
>       at a time.
>       (vst4_u64): Likewise.
>       (vst4_f64): Likewise.
>       (vst4_s8): Likewise.
>       (vst4_p8): Likewise.
>       (vst4_s16): Likewise.
>       (vst4_p16): Likewise.
>       (vst4_s32): Likewise.
>       (vst4_u8): Likewise.
>       (vst4_u16): Likewise.
>       (vst4_u32): Likewise.
>       (vst4_f16): Likewise.
>       (vst4_f32): Likewise.
>       (vst4_p64): Likewise.
>       (vst4q_s8): Likewise.
>       (vst4q_p8): Likewise.
>       (vst4q_s16): Likewise.
>       (vst4q_p16): Likewise.
>       (vst4q_s32): Likewise.
>       (vst4q_s64): Likewise.
>       (vst4q_u8): Likewise.
>       (vst4q_u16): Likewise.
>       (vst4q_u32): Likewise.
>       (vst4q_u64): Likewise.
>       (vst4q_f16): Likewise.
>       (vst4q_f32): Likewise.
>       (vst4q_f64): Likewise.
>       (vst4q_p64): Likewise.
> 
> gcc/testsuite/ChangeLog:
> 
>       * gcc.target/aarch64/vector_structure_intrinsics.c: Add new
>       tests.