Hi Segher,

On 7/27/21 9:23 AM, Segher Boessenkool wrote:
On Mon, Jul 26, 2021 at 10:26:25PM -0500, Bill Schmidt wrote:
Right now I just make the two generated
.h files depend on the generated .c file, which works since they are all
generated together or none of them are generated.  That seems simple
enough and more self-documenting to me.
It only works if you make sure the updates to the .c file are always
seen by make only after the updates to the .h files are visible.  The
window in which it can race is small, but you have to make it empty :-(

If you can guarantee that (ordering the fclose()s appropriately is
enough I believe -- and add a comment for that :-) ) this should be
fine, sure.

Good point.  I have a small race because rs6000-builtins.c isn't closed after rs6000-vecdefines.h.  I'll repair that as part of this patch and add commentary.

Thanks again for the review!

Bill

Reply via email to