Hi Segher,

On 8/10/21 12:34 PM, Segher Boessenkool wrote:
On Tue, Aug 10, 2021 at 11:17:05AM -0500, will schmidt wrote:
On Thu, 2021-07-29 at 08:30 -0500, Bill Schmidt wrote:
+; This will break for long double == _Float128.  libgcc history.
+  const long double __builtin_pack_longdouble (double, double);
+    PACK_TF packtf {}
Add a few more words to provide bigger hints for future archeological
digs?  (This is perhaps an obvious issue, but I'd need to do some
spelunking)
It is for __ibm128 only, not for other long double formats (we have
three: plain double, double double, IEEE QP).  So maybe the return type
should be changed?  The name of the builtin of course is unfortunate,
but it is too late to change :-)


Yeah...I'm not sure how much flexibility we have here to avoid breaking code in the field, but it's not a big break because whoever may be using it has to be assuming long double = __ibm128, and probably has work to do anyway.

Perhaps I should commit as is for now, and then prepare a separate patch to change this builtin?  There may be test suite fallout, not sure offhand.

Thanks!
Bill



Segher

Reply via email to