Hi Bill, on 2021/8/12 上午12:24, Bill Schmidt wrote: > Hi Kewen, > > On 8/11/21 12:44 AM, Kewen.Lin wrote: >> Hi, >> >> This patch is to make prototypes of some Power10 built-in >> functions consistent with what's in the documentation, as >> well as the vector version. Otherwise, useless conversions >> can be generated in gimple IR, and the vectorized versions >> will have inconsistent types. >> >> Bootstrapped & regtested on powerpc64le-linux-gnu P9 and >> powerpc64-linux-gnu P8. >> >> Is it ok for trunk? > > LGTM. Maintainers, this is necessary in the short term for the old builtins > support, but this fragile thing that people always forget will go away with > the new support. What Kewen is proposing here is correct for now. >
Thanks for your review and good to know we won't have this kind of issue with your new support, nice!! FWIW, for now the bif vectorization still requires this type consistence to make type check happy. BR, Kewen > Thanks, > Bill > >> >> BR, >> Kewen >> ----- >> gcc/ChangeLog: >> >> * config/rs6000/rs6000-call.c (builtin_function_type): Add unsigned >> signedness for some Power10 bifs.
