2012/2/23 Jakub Jelinek <ja...@redhat.com>:
> On Thu, Feb 23, 2012 at 05:56:11PM +0100, Kai Tietz wrote:
>> --- gcc.dg/pack-test-5.c      (revision 184486)
>> +++ gcc.dg/pack-test-5.c      (working copy)
>> @@ -1,6 +1,7 @@
>>  /* PR c/11446: packed on a struct takes precedence over aligned on the type
>>     of a field.  */
>>  /* { dg-do run } */
>> +/* { dg-options "-mno-ms-bitfields" { target *-*-mingw* } } */
>
> Shouldn't this be dg-additional-options instead?

Right, I will adjust it.

>> --- gcc.dg/Wpadded.c  (revision 184486)
>> +++ gcc.dg/Wpadded.c  (working copy)
>> @@ -6,6 +6,7 @@
>>     We won't get a warning anyway if the target has "packed" structure
>>     layout.  */
>>  /* { dg-options "-Wpadded -fpack-struct=8" } */
>> +/* { dg-options "-mno-ms-bitfields" { target *-*-mingw* } } */
>
> And above too?

Yes, I will do.

>> --- gcc.dg/tls/opt-11.c       (revision 184486)
>> +++ gcc.dg/tls/opt-11.c       (working copy)
>> @@ -3,7 +3,7 @@
>>  /* { dg-add-options tls } */
>>
>>  extern void abort (void);
>> -extern void *memset (void *, int, __SIZE_TYPE__);
>> +__extension__ extern void *memset (void *, int, __SIZE_TYPE__);
>
> Why?  I don't see extensions anywhere.  Or is __SIZE_TYPE__ on mingw
> long long and requires __extension__?  If yes, it should at least go
> right before the argument, but perhaps then it should be already
> in the __SIZE_TYPE__ macro.

The issue is that for LLP64 target __SIZE_TYPE__ is 'unsigned long long'.

Regards,
Kai

Reply via email to