On Mon, Sep 27, 2021 at 4:38 AM Geng Qi via Gcc-patches < gcc-patches@gcc.gnu.org> wrote:
> gcc/ChangeLog: > * config/riscv/riscv.md > (<u>muldi3_highpart): Rename to <su>muldi3_highpart. > (<u>mulditi3): Emit <su>muldi3_highpart. > (<u>mulsi3_highpart): Rename to <su>mulsi3_highpart. > (<u>mulsidi3): Emit <su>mulsi3_highpart. > This doesn't build on top of tree sources. It is missing the mulv<mode>3_highpart change I mentioned in the riscv-gcc review. Also, I prefer that the order of the changelog entries match the order of hunks in the patch, it is easier to review that way. Otherwise, the patch is OK and I committed it with minor changes. Since I changed it, I need to send the patch I did actually commit. Jim
