On 10/1/21 15:52, Nick Huang wrote:
...the subject line for the commit should be the first line of the
commit message, followed by a blank line, followed by the description of
the patch; without the subject line, git format-patch thought your whole
description was the subject of the patch.
oh, I didn't realize this without your mentioning it. I read this guide
(https://gcc.gnu.org/codingconventions.html#ChangeLogs) many times
and still don't get this. I guess it was written long long ago.
FYI that's a git thing, not a ChangeLog thing. From the git
format-patch manual:
By default, the subject of a single patch is "[PATCH] " followed by the
concatenation of lines from the commit message up to the first blank
line (see the DISCUSSION section of git-commit(1)).
And from git-commit(1):
Though not required, it’s a good idea to begin the commit message with
a single short (less than 50 character) line summarizing the change,
followed by a blank line and then a more thorough description. The text
up to the first blank line in a commit message is treated as the commit
title, and that title is used throughout Git. For example, git-format-
patch(1) turns a commit into email, and it uses the title on the
Subject line and the rest of the commit in the body.
But yes, it would be good to give more of this instruction in the gcc
contribute.html.
Jason
