> We have quite a number of "default" returns that cannot be reached. > One is particularly interesting since it says (see patch below): > > default: > gcc_unreachable (); > } > /* We can get here with --disable-checking. */ > return false; > > which suggests that _maybe_ the intention was to have the > gcc_unreachable () which expands to __builtin_unreachable () > with --disable-checking and thus a fallthru to "somewhere" > be catched with a "sane" default return value rather than > falling through to the next function or so. BUT - that > isn't what actually happens since the 'return false' is > unreachable after CFG construction and will be elided.
I think this is just remat of times we did not have __builtin_unreachable. I like the idea of removing the redundant code. Honza
