On 10/12/2021 15.20, Olivier Hainque wrote: > Hi again Rasmus, > >> On 1 Nov 2021, at 10:34, Rasmus Villemoes <r...@rasmusvillemoes.dk> wrote: >> >> When the translation unit itself creates pointers to the ctors/dtors >> in a specific section handled by the linker (whether .init_array or >> .ctors.*), there's no reason for the functions to have external >> linkage. That ends up polluting the symbol table in the running >> kernel. >> >> This makes vxcrtstuff.c on par with the generic crtstuff.c which also >> defines e.g. frame_dummy and __do_global_dtors_aux static. >> >> libgcc/ >> * config/vxcrtstuff.c: Make constructor and destructor >> functions static when possible. > > > This is OK, can you please commit?
Well, yes, but it depends contextually (but not functionally) on patch 2/4. Should I redo this one, or can I get you to take a look at 2/4 first? You've already ok'ed 1/4 and 4/4 (which were anyway independent of each other and 2,3) and I've committed those Rasmus
