On Sat, Dec 18, 2021 at 3:13 AM Sören Tempel <soe...@soeren-tempel.net> wrote: > > Andrew Pinski <pins...@gmail.com> wrote: > > I think it should check OPTION_MUSL at runtime instead of > > TARGET_GLIBC_MAJOR at compile time. > > or rather opts->x_linux_libc == LIBC_MUSL > > The others should be done similarly too. > > Thanks for pointing this out, I wasn't aware of OPTION_MUSL and > OPTION_GLIBC. However, I am wondering if isn't more useful to whitelist > this feature on glibc instead of blacklisting it on musl? I was > operating on the assumption that other libc implementations (uclibc, > bionic, dietlibc, …) do also not support the required pthread_t fields, > i.e. that glibc is the only libc where this feature actually works.
yes checking OPTION_GLIBC is better really. Saying glibc only is better than saying it does not work on musl in this case. Though I think opts->x_linux_libc == LIBC_GLIBC is the more correct fix for this function as we are passed down the opts struction and all. Thanks, Andrew Pinski > > Greetings, > Sören
