On 1/17/22 1:29 AM, Richard Biener wrote:
On Mon, Jan 17, 2022 at 4:15 AM Sandra Loosemore
<san...@codesourcery.com> wrote:

On 1/8/22 9:24 PM, Sandra Loosemore wrote:
This patch fixes the ICE I reported in PR103163.  We were initializing
stack_limit_rtx before the register properties it depends on were
getting set.  I moved it to the same function where stack_pointer_rtx,
frame_pointer_rtx, etc are being initialized.

Besides nios2 where I observed it, this bug was also reported to affect
powerpc.  Anybody want to check it there?  Otherwise, OK to check in?

Ping?

https://gcc.gnu.org/pipermail/gcc-patches/2022-January/587958.html

This move will now also re-initialize the pointer during target_reinit (),
is that desired and correct?

I did consider that when I wrote the patch -- I can't claim to be an expert on the re-initialization parts of the compiler any more (it's been so long since I worked on that refactoring, and my brain is suffering from bit rot), but it seems reasonable to handle stack_limit_rtx the same way as other frame-related rtx variables, in case the register properties have changed in some way that would affect them.

-Sandra

Reply via email to