On Mon, Mar 12, 2012 at 12:02 AM, H.J. Lu <hongjiu...@intel.com> wrote:

> leave_rex64 works on DImode and sse3_monitor64 works on Pmode.  This
> patch properly sets ix86_gen_leave and ix86_gen_monitor, depending on
> TARGET_64BIT and Pmode.  Tested on Linux/x86-64.  OK for trunk?
> 2012-03-11  H.J. Lu  <hongjiu...@intel.com>
>        * config/i386/i386.c (ix86_option_override_internal): Properly
>        set ix86_gen_leave and ix86_gen_monitor.  Check Pmode == DImode.
>        * config/i386/sse.md (sse3_monitor64): Renamed to ...
>        (sse3_monitor64_<mode>): This.

Please provide more descriptive ChangeLog. You are changing the check
on quite some global variables, please state them explicitly.

Otherwise the patch is OK.

BTW: I sincerely hope you reviewed all the places where these globals
are used...


Reply via email to