On Thu, Feb 17, 2022 at 2:45 AM Mark Wielaard <m...@klomp.org> wrote: > > Ping. Is this OK to commit now? > I am not sure who can approve this. > > On Sun, Jan 16, 2022 at 01:35:34AM +0100, Mark Wielaard wrote: > > Rust symbols can have a .suffix because of compiler transformations. > > These can be ignored in the demangled name. Which is what this patch > > implements. By stopping at the first dot for v0 symbols and searching > > backwards to the ending 'E' for legacy symbols. > > > > An alternative implementation could be to follow what C++ does and > > represent these as [clone .suffix] tagged onto the demangled name. > > But this seems somewhat confusing since it results in a demangled > > name that cannot be mangled again. And it would mean trying to > > decode compiler internal naming. > > > > https://bugs.kde.org/show_bug.cgi?id=445916 > > https://github.com/rust-lang/rust/issues/60705 > > > > libiberty/Changelog > > > > * rust-demangle.c (rust_demangle_callback): Ignore everything > > after '.' char in sym for v0. For legacy symbols search > > backwards to find the last 'E' before any '.'. > > * testsuite/rust-demangle-expected: Add new .suffix testcases.
This is OK. Thanks. Ian
