Hi!

On Mon, Feb 21, 2022 at 12:37:56AM +0100, pku...@freebsd.org wrote:
> From: Piotr Kubaj <pku...@freebsd.org>
> 
> While FreeBSD currently uses 64-bit long double, there should be no
> problem with adding support for float128.
> 
> Signed-off-by: Piotr Kubaj <pku...@freebsd.org>

This needs a changelog.  The entry for configure should just say
"Regenerate." btw :-)

So, I had some problems with this.  Firstly, the test does not make very
much sense, or rather, it is very indirect.  But you copied this from
the Linux code, so :-)

Secondly, I needed to think about if this code should just be shared
between the two then.  Copied code easily turns into a maintenance
nightmare, after all.

And then I just forgot, it fell off my to-do lists, sorry.

The patch is okay for trunk, with a suitable changelog.  Thanks!  Do you
want backports for this as well?


Segher

Reply via email to