On Wed, 2022-03-23 at 11:47 +0530, Avinash Sonawane wrote: > Apologies! Forgot to attach the patch v2. > > Done now.
Thanks for the patch! (forgetting to attach it is something of a rite of passage) The content of the v2 patch looks good to me; I tried regenerating the manpage and I think it's a nice improvement in readability. I double- checked the options and I think you got it all correct. I wondered if there's a dedicated syntax for adding a cautionary note to a texinfo document, but there doesn't seem to be, so that part of the patch is good as-is. This is almost ready to push to trunk, but there are a couple of extra tasks needed to be done: (a) the patch needs a ChangeLog entry in its commit message to pass our git hooks, giving a brief description of what the change is. See https://gcc.gnu.org/codingconventions.html#ChangeLogs and you can use ./contrib/gcc-changelog/git_check_commit.py HEAD to test that the ChangeLog message in the git commit will be pushable. (b) the patch is now sufficiently large that it might be above the threshold where the FSF cares about copyright, so please add a sign-off line to the patch to certify that you wrote it (and various other legal niceties). See https://gcc.gnu.org/dco.html Some more notes on GCC patches can be seen at: https://gcc.gnu.org/contribute.html Thanks again for the patch; let me know if anything's unclear. Dave
