2012/3/16 Paweł Sikora:
>> Should the addition be \$$ to escape it for the shell as well as for make?
>> (I know it works, but that might not be true for all shells.)
> i don't think that $, could be expaneded by any shell.

I'm not worried about it not expanding, but rather being rejected as
invalid syntax - but maybe it's fine.  It certainly works OK with bash
and ksh.

>> The diff for Makefile.in is unnecessary, as it should be regenerated
>> from Makefile.am
>> Apart from that the patch looks good, I've CC'd gcc-patches, could you
>> provide a changelog entry?
> attached. i hope it's correct :)

Looks great, thanks.

Reply via email to