On Mar 16, 2012, at 3:03 PM, Steven Bosscher wrote:
> On Fri, Mar 16, 2012 at 10:54 PM, Mike Stump <mikest...@comcast.net> wrote:
>> This removes some wrong code.
>> Ok?
> ChangeLog is missing.

        * emit-rtl.c (immed_double_const): Remove bogus assert.

> Tested how?

Compiles a user program for my port.

> And why is this wrong anyway?

It is wrong because it can assert.  The code can generate a constant for every 
inbound value that it asserts for, so trivially, it is wrong.  If it were 
correct, it would not assert for values it can handle.  For it to be correct, 
there would have to exist a value for which the code fails.  The value that 
failed for me was 0, not a terribly uncommon value.

Reply via email to