Hi Will, on 2022/5/26 04:25, will schmidt via Gcc-patches wrote: > [PATCH, rs6000] Clean up the option_mask defines > > Hi, > > We have an assortment of MASK and OPTION_MASK #defines throughout > the rs6000 code, MASK_ALTIVEC and OPTION_MASK_ALTIVEC as an example. > > We currently #define the MASK_<xxxx> entries to their OPTION_MASK_<xxxx> > equivalents so the two names could be used interchangeably. > > The mapping is in place from when we switched from using > target_flags to rs6000_isa_flags via > commit 4d9675496a28ef6184f2a9c3ac5e6e3ea63606c1 in 2012. > > This patch converts the references for most of the lingering MASK_* > values to OPTION_MASK_* and removes the now redundant defines. >
Nice, thanks for the cleanup! > I have split this into multiple parts due to size. > I guess they can be bootstrapped & regressed incrementally? I found there are still some masks left: MASK_POWERPC64, MASK_64BIT and MASK_LITTLE_ENDIAN. Is there one part 4 for them? Or is there some particular reason not to clean up them? BR, Kewen
