On Tue, 20 Mar 2012, Tristan Gingold wrote: > > On Mar 20, 2012, at 5:01 PM, Richard Guenther wrote: > > > On Tue, 20 Mar 2012, Tristan Gingold wrote: > > > >> > >> On Mar 20, 2012, at 3:19 PM, Richard Guenther wrote: > >> > >> [...] > >>> > >>> I'd rather get away from using a global main_identifier_node, instead > >>> make that frontend specific, and introduce targetm.main_assembler_name > >>> which the assembler-name creating langhook would make sure to use > >>> when mangling what the FE thinks main is. main_identifier_node should > >>> not serve any purpose outside of Frontends. > >>> > >>> But I see both as a possible cleanup opportunity, not a necessary change. > >> > >> Something along these lines ? > > > > Yes, but I'd simply call the hook at the places you now use > > main_assembler_name and not create a global tree node for it. > > But we use it at the beginning of graph_finalize_function, so caching it > makes sense, doesn't it ?
Well, maybe ;) I have no strong opinion here. Richard.