On Wed, Mar 21, 2012 at 9:35 PM, Diego Novillo <dnovi...@google.com> wrote:
> On 3/21/12 3:30 PM, Steven Bosscher wrote:
>> +/* FIXME: Trunk is at GCC 4.8 now and the above problem still hasn't been
>> +   addressed properly.  This caused PR 52640 due to O(external_decls**2)
>> +   lookups in the pending_assemble_externals queue in assemble_external.
>> +   Paper over with this pointer set.  (And pending_assemble_externals
>> even
>> +   was a TREE_LIST before?!)  */
>> +static struct pointer_set_t *pending_assemble_externals_set;
> Can you add some description on what this pointer set does?

Done, I hope you agree it's sufficiently clear now what this set is for.

> OK for all release branches (if they are open for fixes).

I've committed a version to the release branches where the
pending_assemble_externals remains a TREE_LIST. I saw no reason to
complicate the patch more than strictly necessary for the release
branches. For trunk I'm trying to make pending_assemble_externals go


Reply via email to