On Sat, 2022-07-30 at 14:22 +0100, Maciej W. Rozycki wrote: > On Mon, 6 Jun 2022, Dimitrije Milosevic wrote: > > > * config/mips/mips.cc (mips_asan_shadow_offset): Reformat > > to handle the N32 ABI. > > That's not what the change does. > > > * config/mips/mips.h (SUBTARGET_SHADOW_OFFSET): Remove > > the macro, as it is not needed anymore. > > Why is the macro not needed anymore?
Because it's only used by mips_asan_shadow_offset and now we directly code its content into mips_asan_shadow_offset. SUBTARGET_SHADOW_OFFSET is only needed if a different subtarget (say, mips64el-freebsd) needs a different shadow offset. But for MIPS we don't have any subtarget other than mips*-linux-gnu* supporting ASAN so we can omit SUBTARGET_SHADOW_OFFSET and fold the content directly into the asan_shadow_offset target hook. RISCV port does the same. -- Xi Ruoyao <xry...@xry111.site> School of Aerospace Science and Technology, Xidian University
