Stafford, All, On 2022-10-01 11:35 +0000, Stafford Horne spake thusly: > On Thu, Sep 29, 2022 at 03:57:40PM +0100, Stafford Horne wrote: > > This was found when testing buildroot with linuxthreads enabled. In > > this case, the build passes --disable-tls to the toolchain during > > configuration. After building the OpenRISC toolchain it was still > > generating TLS code sequences and causing linker failures such as: > > > > ..../or1k-buildroot-linux-uclibc-gcc -o gpsd-3.24/gpsctl .... -lusb-1.0 > > -lm -lrt -lnsl > > ..../ld: ..../sysroot/usr/lib/libusb-1.0.so: undefined reference to > > `__tls_get_addr' > > > > This patch fixes this by disabling tls for the OpenRISC target when > > requested > > via --disable-tls. > > > > Tested-by: Yann E. MORIN <[email protected]> > > > > gcc/ChangeLog: > > > > * config/or1k/or1k.cc (TARGET_HAVE_TLS): Only define if > > HAVE_AS_TLS is defined. > > I have pushed this upstream now. Adding buildroot patches should be easy to > do > now.
That's great, thanks for fixing this! :-) I'll poke my work alter-ego on Monday to look at providing the backports for Buildroot. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
