On Mon, 2022-10-10 at 10:49 -0700, Caroline Tice via Gcc-patches wrote: > Is "if (VTV_PAGE_SIZE != sysconf (_SC_PAGE_SIZE))" going to fail for > loongarch?
Because LoongArch systems may have 4KB, 16KB, or 64KB pages. > If not, why do you need to insert anything here at all? If so, > perhaps you could write something similar to sysconf_SC_PAGE_SIZE for > loongarch (as was done for __CYGWIN__ & __MINGW32__)? I'd like to ask a question: if we set VTV_PAGE_SIZE to 64KB and make the special case, will libvtv work for 4KB and 16KB pages? (If I read code correctly, setting VTV_PAGE_SIZE to 4KB will obviously break 16KB or 64KB configuration.) If VTV_PAGE_SIZE == sysconf (_SC_PAGE_SIZE) is strictly required for libvtv we'll have to keep the check as-is and then we'll only support 16KB page configuration (which is the default in Linux kernel configuration for LoongArch). -- Xi Ruoyao <xry...@xry111.site> School of Aerospace Science and Technology, Xidian University
