On Tue, Oct 04, 2022 at 21:12:03 +0200, Harald Anlauf wrote: > Am 04.10.22 um 17:12 schrieb Ben Boeckel: > > This patch implements support for [P1689R5][] to communicate to a build > > system the C++20 module dependencies to build systems so that they may > > build `.gcm` files in the proper order. > > Is there a reason that you are touching so many frontends?
Just those that needed the update for `cpp_finish`. It does align with those that will (eventually) need this support anyways (AFAIK). > > diff --git a/gcc/fortran/cpp.cc b/gcc/fortran/cpp.cc > > index 364bd0d2a85..0b9df9c02cd 100644 > > --- a/gcc/fortran/cpp.cc > > +++ b/gcc/fortran/cpp.cc > > @@ -712,7 +712,7 @@ gfc_cpp_done (void) > > FILE *f = fopen (gfc_cpp_option.deps_filename, "w"); > > if (f) > > { > > - cpp_finish (cpp_in, f); > > + cpp_finish (cpp_in, f, NULL); > > fclose (f); > > } > > else > > @@ -721,7 +721,7 @@ gfc_cpp_done (void) > > xstrerror (errno)); > > } > > else > > - cpp_finish (cpp_in, stdout); > > + cpp_finish (cpp_in, stdout, NULL); > > } > > > > cpp_undef_all (cpp_in); > > Couldn't you simply default the third argument of cpp_finish() to NULL? I could do that. Wasn't sure how much that would be acceptable given that it is a "silent" change, but it would reduce the number of files touched here. Thanks, --Ben