On Fri, Nov 18, 2022 at 3:47 PM Segher Boessenkool <seg...@kernel.crashing.org> wrote: > > [ Please cc: me and Ke Wen on rs6000 patches ] > > On Thu, Nov 17, 2022 at 07:54:29AM +0800, Hongyu Wang wrote: > > r13-3950-g071e428c24ee8c enables O2 small loop unrolling, but it breaks > > -fno-unroll-loops for rs6000 with loop_unroll_adjust hook. Adjust the > > option handling and target hook accordingly. > > NAK. > > This is wrong. -munroll-only-small-loops does not enable loop > unrolling; doing that with a machine flag is completely unmaintainable, > also for people using different targets.
I suggested that because doing it fully in the backend by twiddling -funroll-loops is unmaintainable as well. > Something in your patch was wrong, please fix that (or revert the > patch). You should not have to touch config/rs6000/ at all. Sure something is wrong, but I think there's the opportunity to simplify rs6000/ and s390x/, the only other two implementors of the hook used. Richard. > > Segher
