On Sat, Feb 11, 2023 at 4:31 PM Antoni Boucher via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > Hi. > This patch adds support for machine-dependent builtins in libgccjit > (bug 108762). > > There are two things I don't like in this patch: > > 1. There are a few functions copied from the C frontend > (common_mark_addressable_vec and a few others). > > 2. Getting a target builtin only works from the second compilation > since the type information is recorded at the first compilation. I > couldn't find a way to get the builtin data without using the langhook. > It is necessary to get the type information for type checking and > instrospection. > > Any idea how to fix these issues?
Seems like you should do this patch in a few steps; that is split it up. Definitely split out GCC_JIT_TYPE_BFLOAT16 support. I also think the vector support should be in a different patch too. Splitting out these parts would definitely make it easier for review and make incremental improvements. Thanks, Andrew Pinski > > Thanks for the review.
